Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 132AA18168 for ; Mon, 30 Nov 2015 19:05:25 +0000 (UTC) Received: (qmail 23507 invoked by uid 500); 30 Nov 2015 19:05:24 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 23469 invoked by uid 500); 30 Nov 2015 19:05:24 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 23448 invoked by uid 99); 30 Nov 2015 19:05:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 19:05:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7ED2B1DDC3F; Mon, 30 Nov 2015 19:05:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8515473773721864772==" MIME-Version: 1.0 Subject: Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase From: "Sid Wagle" To: "Sid Wagle" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 30 Nov 2015 19:05:22 -0000 Message-ID: <20151130190522.1841.68955@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40750/ X-Sender: "Sid Wagle" References: <20151130171129.28067.98856@reviews.apache.org> In-Reply-To: <20151130171129.28067.98856@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============8515473773721864772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 30, 2015, 5:11 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java, line 1155 > > > > > > Can we add some log retention setting to avoid too much gc log from being retained. Also, does Occupancy ratio make sense for collector? - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40750/#review108329 ----------------------------------------------------------- On Nov. 26, 2015, 2:08 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40750/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 2:08 p.m.) > > > Review request for Ambari and Sid Wagle. > > > Bugs: AMBARI-14088 > https://issues.apache.org/jira/browse/AMBARI-14088 > > > Repository: ambari > > > Description > ------- > > Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector. > > Error trace: > > javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms. > at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3fc5212 > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 5e7335a > > Diff: https://reviews.apache.org/r/40750/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > > --===============8515473773721864772==--