Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5A7D18F7E for ; Mon, 30 Nov 2015 05:41:30 +0000 (UTC) Received: (qmail 64333 invoked by uid 500); 30 Nov 2015 05:41:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 64292 invoked by uid 500); 30 Nov 2015 05:41:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 64277 invoked by uid 99); 30 Nov 2015 05:41:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 05:41:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 68C722AD766; Mon, 30 Nov 2015 05:41:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3469225102290278290==" MIME-Version: 1.0 Subject: Re: Review Request 40436: Select on large BIGINT in Ambari Hive View returns incorrect value From: "Jaimin Jetly" To: "DIPAYAN BHOWMICK" , "Rohit Choudhary" , "Jaimin Jetly" Cc: "Nitiraj Rathore" , "Ambari" Date: Mon, 30 Nov 2015 05:41:28 -0000 Message-ID: <20151130054128.28068.54125@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40436/ X-Sender: "Jaimin Jetly" References: <20151118102044.6715.14034@reviews.apache.org> In-Reply-To: <20151118102044.6715.14034@reviews.apache.org> Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============3469225102290278290== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40436/#review108286 ----------------------------------------------------------- Ship it! Ship It! - Jaimin Jetly On Nov. 18, 2015, 10:20 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40436/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 10:20 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary. > > > Bugs: AMBARI-13938 > https://issues.apache.org/jira/browse/AMBARI-13938 > > > Repository: ambari > > > Description > ------- > > Server was sending the data properly. > But Javascript does not support number with such large number of digits, so It was approximating. > Changes : > Now all the data sent will be strings instead of numbers. > > > Diffs > ----- > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 735e63d > > Diff: https://reviews.apache.org/r/40436/diff/ > > > Testing > ------- > > Manual test from UI and development tools to check if big numbers are coming correctly or not and other funcionalities working properly or not. > > > Thanks, > > Nitiraj Rathore > > --===============3469225102290278290==--