Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2E101768C for ; Wed, 25 Nov 2015 01:11:28 +0000 (UTC) Received: (qmail 42489 invoked by uid 500); 25 Nov 2015 01:11:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 42453 invoked by uid 500); 25 Nov 2015 01:11:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 42439 invoked by uid 99); 25 Nov 2015 01:11:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2015 01:11:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 044E02E3FED; Wed, 25 Nov 2015 01:11:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8359440165039720968==" MIME-Version: 1.0 Subject: Re: Review Request 40682: PXF should get secured when security is enabled on cluster via kerberos wizard on ambari From: "jun aoki" To: "Oleksandr Diachenko" , "jun aoki" Cc: "bhuvnesh chaudhary" , "Ambari" Date: Wed, 25 Nov 2015 01:11:27 -0000 Message-ID: <20151125011127.24387.8742@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "jun aoki" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40682/ X-Sender: "jun aoki" References: <20151125005411.24387.13559@reviews.apache.org> In-Reply-To: <20151125005411.24387.13559@reviews.apache.org> Reply-To: "jun aoki" X-ReviewRequest-Repository: ambari --===============8359440165039720968== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40682/#review107884 ----------------------------------------------------------- ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py (line 106) I noticed ConfigDictionary is used before it is passed to one of Resources (in this case XmlConfig). I know ConfigDictionary is to make a dictionary immutable. But Is it necessary for this use case? - jun aoki On Nov. 25, 2015, 12:54 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40682/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 12:54 a.m.) > > > Review request for Ambari, jun aoki and Oleksandr Diachenko. > > > Bugs: AMBARI-14053 > https://issues.apache.org/jira/browse/AMBARI-14053 > > > Repository: ambari > > > Description > ------- > > PXF should get secured when security is enabled on cluster via kerberos wizard on ambari. Need to add kerberos.json and the relevant code. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/PXF/3.0.0/kerberos.json PRE-CREATION > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py a4986c9 > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py dd0031c > > Diff: https://reviews.apache.org/r/40682/diff/ > > > Testing > ------- > > yes > > > Thanks, > > bhuvnesh chaudhary > > --===============8359440165039720968==--