Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 239EE18E30 for ; Tue, 24 Nov 2015 16:06:29 +0000 (UTC) Received: (qmail 41936 invoked by uid 500); 24 Nov 2015 16:06:29 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 41902 invoked by uid 500); 24 Nov 2015 16:06:29 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 41888 invoked by uid 99); 24 Nov 2015 16:06:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 16:06:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 32F4D2E3D18; Tue, 24 Nov 2015 16:06:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9017269082466138623==" MIME-Version: 1.0 Subject: Re: Review Request 40650: Allow sending metrics as an async op with timeout and cancel From: "Dmytro Sen" To: "Sumit Mohanty" , "Sid Wagle" Cc: "Dmytro Sen" , "Ambari" Date: Tue, 24 Nov 2015 16:06:27 -0000 Message-ID: <20151124160627.24387.85082@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40650/ X-Sender: "Dmytro Sen" References: <20151124154937.26797.67483@reviews.apache.org> In-Reply-To: <20151124154937.26797.67483@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============9017269082466138623== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40650/ ----------------------------------------------------------- (Updated Ноя. 24, 2015, 4:06 п.п.) Review request for Ambari, Sumit Mohanty and Sid Wagle. Repository: ambari Description ------- Noticed that there are no HDFS / YARN metrics sent to AMS. HBase and host metrics are all ok. There was a time where due to lack of resources AMS HBase was not keeping up with the writes and customer had to reconfigure to get it to work. Although after restarting AMS only the host and HBase metrics start showing. Note: Historical AMS data still exists for HDFS and YARN, which means the Sinks were operational for some time. Diffs (updated) ----- ambari-metrics/ambari-metrics-common/pom.xml 31c6b2e ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 5aba016 ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 4f9b93e ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java 647e026 ambari-metrics/ambari-metrics-hadoop-sink/pom.xml ae821bf ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 2d171d9 ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java dddbbd0 ambari-metrics/ambari-metrics-kafka-sink/pom.xml 15230aa ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java dd7604b ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java 70f4850 ambari-metrics/ambari-metrics-storm-sink/pom.xml 7446167 ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 3a49e0a ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java a0600e5 Diff: https://reviews.apache.org/r/40650/diff/ Testing ------- Unit tests passed Thanks, Dmytro Sen --===============9017269082466138623==--