Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4390D18B32 for ; Tue, 24 Nov 2015 14:46:13 +0000 (UTC) Received: (qmail 22144 invoked by uid 500); 24 Nov 2015 14:46:13 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 22115 invoked by uid 500); 24 Nov 2015 14:46:13 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 22100 invoked by uid 99); 24 Nov 2015 14:46:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 14:46:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 45D4D2E3D3E; Tue, 24 Nov 2015 14:46:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0713800055772822877==" MIME-Version: 1.0 Subject: Review Request 40646: RU: Downgrade does not restart failed service component From: "Nate Cole" To: "Alejandro Fernandez" , "Jayush Luniya" , "Jonathan Hurley" Cc: "Ambari" , "Nate Cole" Date: Tue, 24 Nov 2015 14:46:11 -0000 Message-ID: <20151124144611.26798.56953@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40646/ X-Sender: "Nate Cole" Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============0713800055772822877== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40646/ ----------------------------------------------------------- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya. Bugs: AMBARI-14041 https://issues.apache.org/jira/browse/AMBARI-14041 Repository: ambari Description ------- Downgrade orchestration will skip components that are on the version that is being targeted for download. This approach works if the failing component has advertised the newer version, but not if it still advertises the old version. Use the UpgradeState.FAILED value for host components when detecting a failure for RU. Also added an NPE fix to AMCImpl that's unrelated Diffs ----- ambari-common/src/main/python/resource_management/libraries/script/script.py 10a9aa6 ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 3394d94 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 443c715 ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 22447d7 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 02721ef ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java 3acfb9f ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 21daed0 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 681ee9b ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 6f8dc32 Diff: https://reviews.apache.org/r/40646/diff/ Testing ------- Manual testing; automated pending Thanks, Nate Cole --===============0713800055772822877==--