Return-Path: 
 <dev-return-96243-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 73817188BC
	for <apmail-ambari-dev-archive@www.apache.org>;
 Tue, 24 Nov 2015 13:47:42 +0000 (UTC)
Received: (qmail 68301 invoked by uid 500); 24 Nov 2015 13:47:42 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 68267 invoked by uid 500); 24 Nov 2015 13:47:40 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 68254 invoked by uid 99); 24 Nov 2015 13:47:39 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 13:47:39 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 6E5672E3CB9;
	Tue, 24 Nov 2015 13:47:38 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5618125814419947077=="
MIME-Version: 1.0
Subject: Re: Review Request 40637: Add recommendations for authorization
 provider(upgrade ambari 1.7.0 -> ambari 2.1.3)
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Jaimin Jetly" <jaimin@hortonworks.com>
Cc: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Tue, 24 Nov 2015 13:47:38 -0000
Message-ID: <20151124134738.26798.51950@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/40637/
X-Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20151124121513.26798.45743@reviews.apache.org>
In-Reply-To: <20151124121513.26798.45743@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5618125814419947077==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40637/#review107777
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 24, 2015, 2:15 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40637/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 2:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-14036
>     https://issues.apache.org/jira/browse/AMBARI-14036
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Basic implementation AMBARI-9587
> 1st task:
> While upgrading a cluster above 2.0.0 Ambari version, if knox topology file is present without authorization provider then add correct authorization provider i.e
> If Ranger plugin is not enabled for Knox then
> <provider> <role>authorization</role> <name>AclsAuthz</name> <enabled>true</enabled> </provider> 
> If Ranger plugin for knox is enabled then
> <provider> <role>authorization</role> <name>XASecurePDPKnox</name> <enabled>true</enabled> </provider> 
> NOTE: If this logic is going in upgrade catalog for 2.0.0 then we can simply modify knox topology to add "<provider> <role>authorization</role> <name>AclsAuthz</name> <enabled>true</enabled> </provider>" as Ranger service itself was added in 2.0.0
> 2nd task:
> Stack advisor right now recommends the value of authorization provider in topology file when ranger plugin is enabled or disabled. But this will happen only if authorization provider tag is present in topology file or else the recommendation logic will be skipped. Stack advisor code needs to be changed so that while enabling or disabling ranger plugin for knox if authorization provider tag does not exist then the corresponding authorization provider tag should be added while sending back recommendation to ambari-web.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 30e4151 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java cc1838b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 7201de8 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java fa3e365 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 0acaaff 
> 
> Diff: https://reviews.apache.org/r/40637/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


--===============5618125814419947077==--