Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D55F6188C7 for ; Mon, 23 Nov 2015 16:29:43 +0000 (UTC) Received: (qmail 18895 invoked by uid 500); 23 Nov 2015 16:29:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 18863 invoked by uid 500); 23 Nov 2015 16:29:43 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 18844 invoked by uid 99); 23 Nov 2015 16:29:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 16:29:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 66A832E35DB; Mon, 23 Nov 2015 16:29:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1135217368761407387==" MIME-Version: 1.0 Subject: Re: Review Request 40599: Backport AMS auto-start and watchdog thread changes to 2.1.2 From: "Dmytro Sen" To: "Sid Wagle" , "Sumit Gupta" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 23 Nov 2015 16:29:41 -0000 Message-ID: <20151123162941.26797.5995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40599/ X-Sender: "Dmytro Sen" References: <20151123162553.26798.73934@reviews.apache.org> In-Reply-To: <20151123162553.26798.73934@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============1135217368761407387== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40599/ ----------------------------------------------------------- (Updated Ноя. 23, 2015, 4:29 п.п.) Review request for Ambari, Sumit Gupta and Sid Wagle. Bugs: AMBARI-14016 https://issues.apache.org/jira/browse/AMBARI-14016 Repository: ambari Description ------- For small sized nodes with all Masters co-hosted, sometimes AMS doesn't start cleanly. We need to leverage the auto-start feature along with watchdog thread. Diffs (updated) ----- ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector dd7ee22 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 43cb554 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 2073d75 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java 30e42f2 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION ambari-server/conf/unix/ambari.properties 361f13f ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml 165b87e ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 734bf69 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py 1afe1d8 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py 00e4123 ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7add394 ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2f75bcf ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json PRE-CREATION Diff: https://reviews.apache.org/r/40599/diff/ Testing ------- Unit tests passed Thanks, Dmytro Sen --===============1135217368761407387==--