Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8228F1867B for ; Thu, 19 Nov 2015 20:47:53 +0000 (UTC) Received: (qmail 32517 invoked by uid 500); 19 Nov 2015 20:47:53 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 32480 invoked by uid 500); 19 Nov 2015 20:47:53 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 32463 invoked by uid 99); 19 Nov 2015 20:47:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2015 20:47:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3F4092E2791; Thu, 19 Nov 2015 20:47:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3187282452686902539==" MIME-Version: 1.0 Subject: Review Request 40499: Create base infrastructure to allow for granular role based access control From: "Robert Levas" To: "Sumit Mohanty" , "Myroslav Papirkovskyy" , "Nate Cole" , "Robert Nettleton" , "Jonathan Hurley" Cc: "Robert Levas" , "Ambari" Date: Thu, 19 Nov 2015 20:47:52 -0000 Message-ID: <20151119204752.1027.12736@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40499/ X-Sender: "Robert Levas" Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============3187282452686902539== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40499/ ----------------------------------------------------------- Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-13947 https://issues.apache.org/jira/browse/AMBARI-13947 Repository: ambari Description ------- Create base infrastructure to allow for granular role based access control. This entails creating a base class to help with authorization checks. The base class is to contain a default authorization check implementation but allow derived classes to override the logic to implement more sophisticated checks. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java cb22ddd ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java d162eec ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d2e7be7 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java f4839e9 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 0621286 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java 090805e ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ResourceTypeEntity.java 3c434ea ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java 9feaf93 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/ResourceType.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java 6d7a573 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 310de34 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 01b69db ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 53277d1 ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java 3a6ad91 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java 6286aea ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 06ae045 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 8e424f7 ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java c5bb6e6 ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 27f6897 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ConfigGroupDAOTest.java 53af8a5 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 7642603 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java edc1428 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestScheduleDAOTest.java 75b937c ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 7873abb ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java c094934 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java a2a94ed ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java b2e2d68 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java 19c0c7f Diff: https://reviews.apache.org/r/40499/diff/ Testing ------- Manual testing # Local test results: [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:01:53.757s [INFO] Finished at: Thu Nov 19 15:30:16 EST 2015 [INFO] Final Memory: 67M/757M [INFO] ------------------------------------------------------------------------ #Jenkins test results: PENDING Thanks, Robert Levas --===============3187282452686902539==--