Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6125318539323487439=="
MIME-Version: 1.0
Subject: Re: Review Request 40270: AMBARI-13863 UI lags and OutOfMemoryError
 seen in
 Ambari server after dashboard metrics' time periods are changed.
From: "Aravindan Vijayan" <avijayan@hortonworks.com>
To: "Sid Wagle" <swagle@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Aravindan Vijayan" <avijayan@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 13 Nov 2015 04:22:26 -0000
Message-ID: <20151113042226.1634.75678@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aravindan Vijayan" <noreply@reviews.apache.org>
References: <20151113033317.1634.8047@reviews.apache.org>
In-Reply-To: <20151113033317.1634.8047@reviews.apache.org>
Reply-To: "Aravindan Vijayan" <avijayan@hortonworks.com>

--===============6125318539323487439==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 13, 2015, 3:33 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java, line 125
> > <https://reviews.apache.org/r/40270/diff/3/?file=1124708#file1124708line125>
> >
> >     Does this mean default seconds padding interval is 1 second?

The default padding interval is 1 second, which will happen only if the precision is SECOND and the number if points is 1.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40270/#review106360
-----------------------------------------------------------


On Nov. 13, 2015, 1:25 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40270/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 1:25 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-13863
>     https://issues.apache.org/jira/browse/AMBARI-13863
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem
> On the Ambari dashboard page, when different time ranges are randomly chosen, the metrics charts stop responding and an OutOfMemory is seen in the Ambari server logs.
> 
> Bug
> In the AMS cache layer, the logic to pad the cache entry map by looking at the delta between the values present in the map. When there is only one data point, it assumes a default pad interval of 15 seconds even if the actual data precision could be in minutes/hours/days.
> 
> Fix
> Change the padding interval logic to use the precision calculated using the requested start and end time. If the precision is in SECONDS, the delta between the values in the map are used.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java ccfb713 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java b35295d 
> 
> Diff: https://reviews.apache.org/r/40270/diff/
> 
> 
> Testing
> -------
> 
> Added unit test for new padding interval calculation method. Relevant unit tests pass. 
> 
> Submitted a patch at Apache to run other unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


--===============6125318539323487439==--