Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72FDE182CD for ; Wed, 11 Nov 2015 18:05:46 +0000 (UTC) Received: (qmail 80846 invoked by uid 500); 11 Nov 2015 18:05:46 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 80812 invoked by uid 500); 11 Nov 2015 18:05:46 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 80791 invoked by uid 99); 11 Nov 2015 18:05:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 18:05:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D46527DA08; Wed, 11 Nov 2015 18:05:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3555604481098729137==" MIME-Version: 1.0 Subject: Re: Review Request 40080: AMBARI-13748: Being able to clean repository cache before installing open source components From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Andrew Onischuk" , "Jayush Luniya" , "Sid Wagle" Cc: "Di Li" , "Ambari" Date: Wed, 11 Nov 2015 18:05:45 -0000 Message-ID: <20151111180545.1681.12706@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40080/ X-Sender: "Alejandro Fernandez" References: <20151111180147.1681.87889@reviews.apache.org> In-Reply-To: <20151111180147.1681.87889@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============3555604481098729137== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 11, 2015, 6:01 p.m., Andrew Onischuk wrote: > > Also can we do the clean for all repositories? That would simply the logics exponentiantialy and help to avoid some bugs. +1 for that. Custom command that can be ran on-demand to clean all repos. We need to be careful if the yum lock is already acquired, we don't want to wait forever. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40080/#review106100 ----------------------------------------------------------- On Nov. 10, 2015, 9:02 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40080/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 9:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush Luniya, and Sid Wagle. > > > Bugs: AMBARI-13748 > https://issues.apache.org/jira/browse/AMBARI-13748 > > > Repository: ambari > > > Description > ------- > > Need a way for Ambari to trigger a repository clean (yum clean expire-cache on rhel, for example) when updating repository files during an Ambari update as well as fresh installation of a cluster. > > Currently, this must be done occasionally through a manual step, and if not done will lead to problems during install. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/libraries/providers/repository.py 11002cc > ambari-common/src/main/python/resource_management/libraries/resources/repository.py 2484d67 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 1dfaa54 > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 05751fa > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 83b6bb5 > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py f9d69a8 > > Diff: https://reviews.apache.org/r/40080/diff/ > > > Testing > ------- > > New unit test. Patch cluster with the changes and run fresh install and rolling upgrade to verify the repo clean up logic was run. > > > Thanks, > > Di Li > > --===============3555604481098729137==--