Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2B5A18816 for ; Tue, 10 Nov 2015 19:26:07 +0000 (UTC) Received: (qmail 58244 invoked by uid 500); 10 Nov 2015 19:26:07 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 58212 invoked by uid 500); 10 Nov 2015 19:26:07 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 58196 invoked by uid 99); 10 Nov 2015 19:26:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 19:26:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4AA0127D9A1; Tue, 10 Nov 2015 19:26:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1421188061658385105==" MIME-Version: 1.0 Subject: Re: Review Request 40099: RU: PreCheck for consistency of password between Ranger and Ambari From: "Jonathan Hurley" To: "Alejandro Fernandez" , "Velmurugan Periasamy" , "Gautam Borad" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Tue, 10 Nov 2015 19:26:07 -0000 Message-ID: <20151110192607.1680.72047@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40099/ X-Sender: "Jonathan Hurley" References: <20151110180502.1681.97926@reviews.apache.org> In-Reply-To: <20151110180502.1681.97926@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============1421188061658385105== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40099/#review105929 ----------------------------------------------------------- Ship it! Ship It! - Jonathan Hurley On Nov. 10, 2015, 1:05 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40099/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. > > > Bugs: AMBARI-13797 > https://issues.apache.org/jira/browse/AMBARI-13797 > > > Repository: ambari > > > Description > ------- > > Need a prereq check to confirm that Ambari's password for Ranger will work against the Ranger server. It's possible to change the password using the Ranger UI, so this check attempts to verify that. > > The Ranger access points are still under investigation, but shouldn't impact the logic of the code. The general rules are: > > - Try to access Ranger using admin credentials. 401=FAIL, 200=PASS, other or IOException: WARN. > - If PASS, check to load the users JSON and look for Ranger Admin User. Do not fail if user doesn't exist (not sync'ed). > - If Ranger Admin User is found, access Ranger with credentials. 401=FAIL, 200=PASS, other or IOException=WARN. > > We only want to FAIL when it's truly known that the credentials are bad. Only PASS when it's truly known the credentials are good. WARNING every other case. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 1908c06 > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/40099/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > > --===============1421188061658385105==--