Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7715916298954694339=="
MIME-Version: 1.0
Subject: Re: Review Request 40080: AMBARI-13748: Being able to clean
 repository cache before installing open source components
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>
Cc: "Di Li" <dili@ca.ibm.com>, "Ambari" <dev@ambari.apache.org>
Date: Tue, 10 Nov 2015 18:46:35 -0000
Message-ID: <20151110184635.1681.75649@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20151109132017.5853.9467@reviews.apache.org>
In-Reply-To: <20151109132017.5853.9467@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============7715916298954694339==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40080/#review105920
-----------------------------------------------------------


Thanks for the contribution. Please include Andrew Onischuk, Sid Waggle, and Jayush Luniya in the code review.


ambari-common/src/main/python/resource_management/libraries/providers/repository.py (line 97)
<https://reviews.apache.org/r/40080/#comment164611>

    Small typo here.


ambari-common/src/main/python/resource_management/libraries/providers/repository.py (line 103)
<https://reviews.apache.org/r/40080/#comment164612>

    Should check that output is not None and len > 2
    
    For line_list, also check the len before attempting to get an index.
    
    Do case insensitive comparison to "yes" by casting 
    to lower(), and same with "suse-" and "opensuse"


ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py (line 56)
<https://reviews.apache.org/r/40080/#comment164615>

    Should this be a Logger.info?


- Alejandro Fernandez


On Nov. 9, 2015, 1:20 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40080/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 1:20 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-13748
>     https://issues.apache.org/jira/browse/AMBARI-13748
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need a way for Ambari to trigger a repository clean (yum clean expire-cache on rhel, for example) when updating repository files during an Ambari update as well as fresh installation of a cluster.
> 
> Currently, this must be done occasionally through a manual step, and if not done will lead to problems during install.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/providers/repository.py 11002cc 
>   ambari-common/src/main/python/resource_management/libraries/resources/repository.py 2484d67 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 1dfaa54 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 05751fa 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 83b6bb5 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py f9d69a8 
> 
> Diff: https://reviews.apache.org/r/40080/diff/
> 
> 
> Testing
> -------
> 
> New unit test. Patch cluster with the changes and run fresh install and rolling upgrade to verify the repo clean up logic was run.
> 
> 
> Thanks,
> 
> Di Li
> 
>


--===============7715916298954694339==--