Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 461F418E91 for ; Tue, 10 Nov 2015 16:23:59 +0000 (UTC) Received: (qmail 74550 invoked by uid 500); 10 Nov 2015 16:23:59 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 74519 invoked by uid 500); 10 Nov 2015 16:23:59 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 74505 invoked by uid 99); 10 Nov 2015 16:23:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 16:23:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8EC9D27D991; Tue, 10 Nov 2015 16:23:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4785145642260680790==" MIME-Version: 1.0 Subject: Review Request 40141: HDP-2.3 does not have the ability to set heapsize for hive components From: "Dmytro Sen" To: "Andrew Onischuk" , "Vitalyi Brodetskyi" Cc: "Dmytro Sen" , "Ambari" Date: Tue, 10 Nov 2015 16:23:58 -0000 Message-ID: <20151110162358.1680.63042@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40141/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============4785145642260680790== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40141/ ----------------------------------------------------------- Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. Bugs: AMBARI-13817 https://issues.apache.org/jira/browse/AMBARI-13817 Repository: ambari Description ------- It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml). Specifically the missing parts are: export SERVICE=$SERVICE if [ "$SERVICE" = "metastore" ]; then export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}" else export HADOOP_HEAPSIZE="{{hive_heapsize}}" fi Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802 ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede Diff: https://reviews.apache.org/r/40141/diff/ Testing ------- Unit tests passed Thanks, Dmytro Sen --===============4785145642260680790==--