Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBDEE18703 for ; Mon, 9 Nov 2015 23:34:57 +0000 (UTC) Received: (qmail 23986 invoked by uid 500); 9 Nov 2015 23:34:57 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 23946 invoked by uid 500); 9 Nov 2015 23:34:57 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 23922 invoked by uid 99); 9 Nov 2015 23:34:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2015 23:34:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D57B727CA6F; Mon, 9 Nov 2015 23:34:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4867317402755062241==" MIME-Version: 1.0 Subject: Review Request 40110: AMBARI-13798 Add ams-site resultset limit property to upgrade From: "Aravindan Vijayan" To: "Sid Wagle" , "Sumit Mohanty" , "Dmytro Sen" Cc: "Aravindan Vijayan" , "Ambari" Date: Mon, 09 Nov 2015 23:34:56 -0000 Message-ID: <20151109233456.5852.88917@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aravindan Vijayan" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40110/ X-Sender: "Aravindan Vijayan" Reply-To: "Aravindan Vijayan" X-ReviewRequest-Repository: ambari --===============4867317402755062241== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40110/ ----------------------------------------------------------- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-13798 https://issues.apache.org/jira/browse/AMBARI-13798 Repository: ambari Description ------- The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path. Change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. Diffs ----- ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java e4d44a7 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede Diff: https://reviews.apache.org/r/40110/diff/ Testing ------- mvn clean test on ambari-metrics. Manual testing done. Added unit test to cover this case. Thanks, Aravindan Vijayan --===============4867317402755062241==--