Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8684729595276429421=="
MIME-Version: 1.0
Subject: Review Request 39883: Alert notification create/edit/duplicate menu
 items should be disabled for non-admin users
From: "Sangeeta Ravindran" <sangeeta.e.ravindran@gmail.com>
To: "Andrii Tkach" <atkach@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Sangeeta Ravindran" <sangeeta.e.ravindran@gmail.com>
Date: Wed, 04 Nov 2015 18:31:07 -0000
Message-ID: <20151104183107.17556.32641@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sangeeta Ravindran" <noreply@reviews.apache.org>
Reply-To: "Sangeeta Ravindran" <sangeeta.e.ravindran@gmail.com>

--===============8684729595276429421==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39883/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-13347
    https://issues.apache.org/jira/browse/AMBARI-13347


Repository: ambari


Description
-------

If you log in as a non-admin operator user, and try to create an alert or edit/duplicate an existing alert and click on Save in the Manager Alert Notifications wizard, the UI seems to hang because the user is an operator and does not have the permission to access the resources related to alert management (underlying error HTTP 403).
The create/edit/alert options should be disabled for non-admin operator users since only admins have privileges to add/edit alert notifications.


Diffs
-----

  ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs ed18c63 
  ambari-web/app/views/main/alerts/manage_alert_notifications_view.js c85d534 
  ambari-web/test/views/main/alerts/manage_alert_notifications_view_test.js a2822ce 

Diff: https://reviews.apache.org/r/39883/diff/


Testing
-------

Did manual verification of the fix. Also updated test in manage_alert_notifications_view_test.js.

Ran "mvn clean test" for ambari-web project and build ran successfully.

10080 tests complete (16 seconds)
105 tests pending


Thanks,

Sangeeta Ravindran


--===============8684729595276429421==--