Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8661510672756944724=="
MIME-Version: 1.0
Subject: Re: Review Request 39918: Finalize is invoked when it is sure to fail
 when there a failures that have been skipped during RU
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jayush Luniya" <jluniya@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 04 Nov 2015 02:51:44 -0000
Message-ID: <20151104025144.17556.86935@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20151104022852.17556.63796@reviews.apache.org>
In-Reply-To: <20151104022852.17556.63796@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============8661510672756944724==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/#review105028
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 4, 2015, 2:28 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39918/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 2:28 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-13704
>     https://issues.apache.org/jira/browse/AMBARI-13704
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
> 
> Debatable whether Express needs this - can be removed if needed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39918/diff/
> 
> 
> Testing
> -------
> 
> Manual verification + automated:
> 
> Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:59.689s
> [INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
> [INFO] Final Memory: 34M/1417M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============8661510672756944724==--