Return-Path: 
 <dev-return-93036-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E7F8118401
	for <apmail-ambari-dev-archive@www.apache.org>;
 Tue,  3 Nov 2015 15:10:06 +0000 (UTC)
Received: (qmail 33210 invoked by uid 500); 3 Nov 2015 15:10:06 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 33180 invoked by uid 500); 3 Nov 2015 15:10:06 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 33168 invoked by uid 99); 3 Nov 2015 15:10:06 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2015 15:10:06 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 0524F1DB253;
	Tue,  3 Nov 2015 15:10:03 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5999520794560798999=="
MIME-Version: 1.0
Subject: Re: Review Request 39904: local variable 'out' referenced before
 assignment
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Tue, 03 Nov 2015 15:10:03 -0000
Message-ID: <20151103151003.16291.22597@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/39904/
X-Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20151103150613.16291.65435@reviews.apache.org>
In-Reply-To: <20151103150613.16291.65435@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5999520794560798999==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39904/#review104928
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 3, 2015, 5:06 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39904/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 5:06 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13697
>     https://issues.apache.org/jira/browse/AMBARI-13697
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> stderr:  
> Traceback (most recent call last):  
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/hook.py", line 38, in <module>  
> BeforeConfigureHook().execute()  
> File "/usr/lib/python2.6/site-
> packages/resource_management/libraries/script/script.py", line 95, in execute  
> method(env)  
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/hook.py", line 33, in hook  
> setup_hadoop()  
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/shared_initialization.py", line 76, in setup_hadoop  
> action = "restart")  
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line
> 148, in __init__  
> self.env.run()  
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/environment.py", line 149, in run  
> self.run_action(resource, action)  
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/environment.py", line 115, in run_action  
> provider_action()  
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/providers/service.py", line 42, in
> action_restart  
> self._exec_cmd("start", 0)  
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/providers/service.py", line 74, in _exec_cmd  
> self, command, self.resource.service_name, ret, out))  
> UnboundLocalError: local variable 'out' referenced before assignment
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/service.py 50167f1 
> 
> Diff: https://reviews.apache.org/r/39904/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


--===============5999520794560798999==--