Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 272221886A for ; Tue, 3 Nov 2015 11:34:39 +0000 (UTC) Received: (qmail 91888 invoked by uid 500); 3 Nov 2015 11:34:36 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 91848 invoked by uid 500); 3 Nov 2015 11:34:36 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 91834 invoked by uid 99); 3 Nov 2015 11:34:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2015 11:34:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 722941DB253; Tue, 3 Nov 2015 11:34:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1867712055477057440==" MIME-Version: 1.0 Subject: Re: Review Request 39864: Changing "Skip service check failure" and "Skip slave component failure" options after RU is kicked off does not work From: "Dmitro Lisnichenko" To: "Alejandro Fernandez" , "Jayush Luniya" Cc: "Nate Cole" , "Ambari" Date: Tue, 03 Nov 2015 11:34:34 -0000 Message-ID: <20151103113434.16291.22318@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39864/ X-Sender: "Dmitro Lisnichenko" References: <20151102215420.28714.83223@reviews.apache.org> In-Reply-To: <20151102215420.28714.83223@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============1867712055477057440== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39864/#review104898 ----------------------------------------------------------- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 2, 2015, 11:54 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39864/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2015, 11:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya. > > > Bugs: AMBARI-13681 > https://issues.apache.org/jira/browse/AMBARI-13681 > > > Repository: ambari > > > Description > ------- > > Previous to this patch, the code would issue an UPDATE statement for all host_role_commands. However, this would never update the JPA-cached values even though the db was correct. Changing each entity resulted in the desired affect. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 7978a7a > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 14af03d > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 1806f4c > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java d7e9149 > > Diff: https://reviews.apache.org/r/39864/diff/ > > > Testing > ------- > > Manual testing: > > Tests run: 3323, Failures: 0, Errors: 0, Skipped: 35 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 39:45.702s > [INFO] Finished at: Mon Nov 02 16:52:17 EST 2015 > [INFO] Final Memory: 34M/1105M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============1867712055477057440==--