Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 367BD187B3 for ; Mon, 2 Nov 2015 14:51:50 +0000 (UTC) Received: (qmail 81853 invoked by uid 500); 2 Nov 2015 14:51:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 81810 invoked by uid 500); 2 Nov 2015 14:51:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 81796 invoked by uid 99); 2 Nov 2015 14:51:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 14:51:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 816D728E783; Mon, 2 Nov 2015 14:51:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6173482804669638083==" MIME-Version: 1.0 Subject: Review Request 39859: Make it configurable as to how frequently ActionScheduler scans DB for tasks From: "Dmytro Sen" To: "Myroslav Papirkovskyy" , "Vitalyi Brodetskyi" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 02 Nov 2015 14:51:45 -0000 Message-ID: <20151102145145.16291.88546@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39859/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============6173482804669638083== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39859/ ----------------------------------------------------------- Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi. Bugs: AMBARI-13678 https://issues.apache.org/jira/browse/AMBARI-13678 Repository: ambari Description ------- ActionScheduler now sleeps only 1 second between scans while it was sleeping for 10 seconds before. We should make it configurable where user can set the delay. Users with slower DB would rather have ActionScheduler not work so aggressively. Currently, it is hard coded to 1 second. bindConstant().annotatedWith(Names.named("schedulerSleeptime")).to(1000L); Lets add a config parameter to ambari.properties - server.execution.scheduler.wait and default should be 1 second. If the value is more than 60 second then it should automatically set to 60 second with a log saying so. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 26e20e8 ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 60217c0 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 0f349fa Diff: https://reviews.apache.org/r/39859/diff/ Testing ------- Unit tests passed Thanks, Dmytro Sen --===============6173482804669638083==--