ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-13965) Ambari CS View "Ambari Cluster URL" setting regex is too restrictive
Date Mon, 23 Nov 2015 09:13:11 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021808#comment-15021808
] 

Hudson commented on AMBARI-13965:
---------------------------------

FAILURE: Integrated in Ambari-branch-2.1 #919 (See [https://builds.apache.org/job/Ambari-branch-2.1/919/])
AMBARI-13965. Ambari CS View "Ambari Cluster URL" setting regex is too (jaimin: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=9d5c4917ed53d8cd984f364d468311370c227c4e])
* contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java
* contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/PropertyValidatorTest.java
* contrib/views/capacity-scheduler/pom.xml


> Ambari CS View "Ambari Cluster URL" setting regex is too restrictive
> --------------------------------------------------------------------
>
>                 Key: AMBARI-13965
>                 URL: https://issues.apache.org/jira/browse/AMBARI-13965
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-views
>    Affects Versions: 2.1.1
>            Reporter: DIPAYAN BHOWMICK
>            Assignee: DIPAYAN BHOWMICK
>             Fix For: 2.1.3
>
>         Attachments: AMBARI-13965_branch-2.1.patch
>
>
> PROBLEM: When configuring the Capacity Scheduler view the customer had to manually define
the ambari server url because normally they access ambari server over SSL through an alias,
which is defined in the commonName of the SSL cert.
> The customer's hostname and cluster name have a - in them. This fails the regex and therefore
the host can't be updated. Since the validator code is running on the server side and not
in Javacript, even if we were to use the REST API to update this it would be the same one
Ambari is already using so I see no workaround for this other than to directly manipulate
the database.
> Specifically the validation I'm talking about is here:
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java
> This regex needs to be relaxed, and ideally if this validation is going to be done it
should be using whatever rules used in Ambari elsewhere. For example if I can create the host
or cluster in Ambari to start with then such a name should never fail a validation rule anywhere
else in Ambari ever for any reason.
> Url like http://c1-node.local:8080/api/v1/clusters/c1 were failing because of the hyphen
in the URL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message