ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 40791: Clean up stop agent to not print unnecessary error message
Date Mon, 30 Nov 2015 10:30:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40791/#review108305
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Nov. 30, 2015, 10:27 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40791/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 10:27 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
> 
> 
> Bugs: AMBARI-14110
>     https://issues.apache.org/jira/browse/AMBARI-14110
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When you restart agent you will see this error:
> ERROR 2015-08-11 16:22:45,384 main.py:317 - Fatal exception occurred:
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 314, in <module>
>     main(heartbeat_stop_callback)
>   File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 250, in main
>     stop_agent()
>   File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 200, in stop_agent
>     sys.exit(1)
> SystemExit: 1
> Looking at the code, it throws exception when PID file exists but its not clear if there
was an attempt to delete the file but that failed.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 74697c5 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 696e597 
> 
> Diff: https://reviews.apache.org/r/40791/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message