ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallav Kulshreshtha" <pallav....@gmail.com>
Subject Review Request 40744: Hive View Settings don't persist properly
Date Thu, 26 Nov 2015 12:32:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40744/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-14060
    https://issues.apache.org/jira/browse/AMBARI-14060


Repository: ambari


Description
-------

- Created dynamic HTML for those settings options which are not present in settings dropdown.
- Adding 'hive.auto.convert.join' setting to the settings list.


Diffs
-----

  contrib/views/hive/src/main/resources/ui/hive-web/app/components/typeahead-widget.js f9233a0

  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings.hbs 55b659a 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 199677d 

Diff: https://reviews.apache.org/r/40744/diff/


Testing
-------

- manually tested
- ember test run
- No new unit test is needed.


Thanks,

Pallav Kulshreshtha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message