ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 40716: AMBARI-14059 AMS config properties may get used before trailing m (unit) is stripped
Date Wed, 25 Nov 2015 19:53:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40716/#review108055
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Nov. 25, 2015, 6:50 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40716/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 6:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14075
>     https://issues.apache.org/jira/browse/AMBARI-14075
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem
> After AMBARI-13978, the ability to specify heap properties for AMS hbase could be done
with or without an "m" suffix. This bug was caused because the property regionserver_heapsize
was used before the trailing m was trimmed.
> 
> Fix
> Moved the trimming of the master and regionserver_heapsize before usage.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
cc69148 
> 
> Diff: https://reviews.apache.org/r/40716/diff/
> 
> 
> Testing
> -------
> 
> Submitted patch through Apache.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message