ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Re: Review Request 40701: Oozie/Hive "Database Name" field validation missed
Date Wed, 25 Nov 2015 11:07:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40701/#review107969
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Nov. 25, 2015, 11:03 a.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40701/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 11:03 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-14061
>     https://issues.apache.org/jira/browse/AMBARI-14061
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> Go to Customize Services page.
> Open Hive (or Oozie) tab.
> Populate "Database Name" field with value contains leading spaces or spaces inside.
> Result: no validation error was appeared.
> Expected result: error was appeared.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
2967184293fea2bde0d186c701912f9ac8262aa7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
b611d496921d1f678851e98308fca36ac5449c3e 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
16e8c64ef41658b80035cb0b0294db6a7a888474 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
681a60caebaabf41b5defad9c4586e911afd68c7 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/configuration/hive-env.xml
d9c535561b976e79e9ca9eaeb99fcef27d6d4319 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/configuration/hive-site.xml
25e1dc2b198d3ed7998cf12ad0ddb12b35cd114c 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/configuration/oozie-site.xml
153bf3dd27eef98b5b8cc325de56a208a88d9bcb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
e00e419efe99861fcc37c02909f9a7269b4ae112 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/HIVE/configuration/hive-site.xml
3d251b3d22251b9a3fbb153b4f46516f82927406 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/OOZIE/configuration/oozie-site.xml
a1afa828ce66d4a9432806e4658c001f47043f5c 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
72e816b85f694328286bacd167cd4325e5138510 
>   ambari-web/app/models/configs/objects/service_config_property.js 9bfb9cf9fbf41850fdd2b80936ef46ad1296609b

>   ambari-web/app/utils/validator.js 3822c671237bbd8f9d760e7118817cbd250e84ba 
> 
> Diff: https://reviews.apache.org/r/40701/diff/
> 
> 
> Testing
> -------
> 
> 10433 tests complete (12 seconds)
>   105 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message