ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sriharsha Chintalapani" <har...@hortonworks.com>
Subject Re: Review Request 40683: Adding a dependency check in KAFKA and STORM for changes in ZOOKEEPER configs.
Date Wed, 25 Nov 2015 01:24:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40683/#review107889
-----------------------------------------------------------

Ship it!


Ship It!

- Sriharsha Chintalapani


On Nov. 25, 2015, 1:19 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40683/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 1:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-14055
>     https://issues.apache.org/jira/browse/AMBARI-14055
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding a dependency check in KAFKA and STORM for changes in ZOOKEEPER configs.
> 
> Problem Seen : 
> ============
> 
> Storm Service check fails after enabling wire encryption in Storm.
> 
> It is expected that Ambari informs the user to restart the affected service components,
in this case changes in Zookeeper config (wire encryption enabled by adding secureClientPort
= 2281 in custom zoo.cfg) should inform user for restarting Storm and Kafka.
> 
> Resolution : 
> ==========
> 
> Added a "configuration-dependencies" of "zookeeper-env" and "zoo.cfg" in Kafka and Storm's
"metainfo.xml" to know about Zookeeper configuration changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metainfo.xml dcfe520

>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml fd5e58d

> 
> Diff: https://reviews.apache.org/r/40683/diff/
> 
> 
> Testing
> -------
> 
> - Tested the dependency of "KAFKA and STORM" on Zookeeper config changes by adding the
following :
>   * secureClientPort = 2281 in Zookeeper's "Custom zoo.cfg".
>   * Dummy addtion test=1 key value pair.
>   * RESTART of STORM and KAFKA affected components worked.
> 
> Screenshot attached.
> 
> - RAN Python UT: PASSES.
> 
> 
> File Attachments
> ----------------
> 
> Showing restart required on STORM and KAFKA after after ZOOKEEPER config change 
>   https://reviews.apache.org/media/uploaded/files/2015/11/25/54a82b41-82a6-472f-9a5a-d587cd4aa8be__Screen_Shot_2015-11-24_at_4.59.35_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message