ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 40646: RU: Downgrade does not restart failed service component
Date Tue, 24 Nov 2015 17:02:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40646/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 12:02 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.


Changes
-------

changed ignored exception to logging a warning


Bugs: AMBARI-14041
    https://issues.apache.org/jira/browse/AMBARI-14041


Repository: ambari


Description
-------

Downgrade orchestration will skip components that are on the version that is being targeted
for download.  This approach works if the failing component has advertised the newer version,
but not if it still advertises the old version.  Use the UpgradeState.FAILED value for host
components when detecting a failure for RU.

Also added an NPE fix to AMCImpl that's unrelated


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 10a9aa6 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 3394d94

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
7cb7f7d 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
63330fc 
  ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 22447d7

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 02721ef

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java
3acfb9f 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
21daed0 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 681ee9b

  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fa6d86a 

Diff: https://reviews.apache.org/r/40646/diff/


Testing
-------

Manual testing

Tests run: 3289, Failures: 0, Errors: 0, Skipped: 20

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:49.032s
[INFO] Finished at: Tue Nov 24 10:32:36 EST 2015
[INFO] Final Memory: 36M/837M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message