ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 40614: Blueprints: Update default values for HDFS proxyuser.group settings
Date Tue, 24 Nov 2015 14:56:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40614/#review107790
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Nov. 23, 2015, 9:37 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40614/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 9:37 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Robert Levas, Sandor Magyari, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14026
>     https://issues.apache.org/jira/browse/AMBARI-14026
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Ambari server handling of proxyuser settings has been updated in the UI's handling
of cluster configuration to use the "*" setting for the default group.
> 
> Since the Blueprint configuration processor still handles configuration separately in
some respects, this default is now handled differently for the most part in Blueprints, as
the Blueprint processor will still set the default to be "users".
> For example, the Blueprint processor currently sets the Hive-specific proxyuser group
property to:
> "hadoop.proxyuser.hive.groups" : "users",
> 
> The Blueprint processor should be updated, such that the default is now "*"
> 
> for this property, and for all other service-specific proxyuser.*.groups properties in
core-site.xml.
> 
> Since not all environments include the "users" group, the "*" group is a more valid default
value for this property. This change will also bring the Blueprint processor more closely
in-line with the behavior of the UI, and so making the configuration more consistent across
both options.
> 
> This patch implements the following:
> 
> 1. Modifies the BlueprintConfigurationProcessor to set the proxyuser setting to be *
as the default value.  As before, any user-defined values will override this default. 
> 2. Updated the associated unit tests to reflect this change.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
0138894 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
c0a6fbc 
> 
> Diff: https://reviews.apache.org/r/40614/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran "mvn clean test" in trunk (all passing)
> 2. Manually verified that deploying a Hive cluster with my changes applied resulted in
the Hive proxyuser.groups setting in core-site having a value of *
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message