ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 40527: AMBARI-11825: Failure to add or install component defined with cardinality ALL
Date Mon, 23 Nov 2015 04:03:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40527/#review107547
-----------------------------------------------------------



ambari-web/app/controllers/wizard/step8_controller.js (lines 1059 - 1068)
<https://reviews.apache.org/r/40527/#comment166771>

    If we are going to support "ALL" cardinlaity for master components then lets not show
any master host component with "ALL" cardinality on "Assign Masters page". It will be confusing
if end-user deselects host components on "Assign Master" page and even after that ambari creates
host component on those hosts.


- Jaimin Jetly


On Nov. 20, 2015, 7:11 a.m., Shantanu Mundkur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40527/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 7:11 a.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-11825
>     https://issues.apache.org/jira/browse/AMBARI-11825
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> A MASTER, SLAVE or CLIENT component defined with a cardinality of ALL results in a failure
while adding the service, upon clicking Deploy, with an error like:
> 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Attempted to
create host_component's which already exist: [clusterName=CLUSTER1, hostName=node1.domain.com,
componentName=MYSERVICE_MASTER],[clusterName=CLUSTER1, hostName=node1.domain.com, componentName=MYSERVICE_MASTER]
> 
> or
> 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Attempted to
create a host_component which already exists: [clusterName=CLUSTER2, hostName=node10.domain.com,
componentName=MYSERVICE_SLAVE]
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 5c4baa3 
>   ambari-web/test/controllers/wizard/step8_test.js 9331db5 
> 
> Diff: https://reviews.apache.org/r/40527/diff/
> 
> 
> Testing
> -------
> 
> (1) "mvn clean test" under ambari-web
>    
>   Results:
>   10388 tests complete (16 seconds)
>   115 tests pending
> 
> (2) Test sin (1) included new test-cases that were added for the Jira.
> 
> (3) Manually tested different scenarios using a custom service with MASTER, SLAVE and
CLIENT components using different combinations of cardinality and using ALL for the defined
components.
> 
> 
> Thanks,
> 
> Shantanu Mundkur
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message