ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleksandr Diachenko" <odiache...@hortonworks.com>
Subject Re: Review Request 40502: Move displayType element for HAWQ/PXF from site_properties.json to stack definition
Date Thu, 19 Nov 2015 23:49:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40502/#review107274
-----------------------------------------------------------

Ship it!


Ship It!

- Oleksandr Diachenko


On Nov. 19, 2015, 10:16 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40502/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 10:16 p.m.)
> 
> 
> Review request for Ambari, jun aoki and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-13929
>     https://issues.apache.org/jira/browse/AMBARI-13929
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Move displayType element for HAWQ/PXF from site_properties.json to stack definition.
> Example:
> {
>     "name": "hawq_master_address_host",
>     "displayType": "componentHost",
>     "filename": "hawq-site.xml",
>     "category": "General",
>     "serviceName": "HAWQ",
>     "index": 0
>   },
> <configuration>
>   <property>
>     <name>hawq_master_address_host</name>
>     <display-name>HAWQ Master</display-name>
>     <value>localhost</value>
>     <description>The host name of HAWQ master.</description>
>     <value-attributes>
>         <type>componentHost</type>
>    </value-attributes>
>   </property>
> Move the displayType to value-attributes tag in hawq-site.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
41b10dc 
>   ambari-web/app/data/HDP2.3/site_properties.js bdb0ef2 
>   ambari-web/test/data/HDP2.3/site_properties_test.js 5179283 
> 
> Diff: https://reviews.apache.org/r/40502/diff/
> 
> 
> Testing
> -------
> 
> mvn test
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message