ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Toader" <stoa...@hortonworks.com>
Subject Re: Review Request 40446: Service install will fail if the property-type attribute of any service config property has a value in a stack not known to ambari-server
Date Thu, 19 Nov 2015 08:20:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40446/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 9:20 a.m.)


Review request for Ambari, Alejandro Fernandez and Sid Wagle.


Changes
-------

rebase on latest trunk


Bugs: AMBARI-13951
    https://issues.apache.org/jira/browse/AMBARI-13951


Repository: ambari


Description
-------

If a property in stack definition has property type which is unknown to Ambari (know property
types are listed in PropertyInfo.PropertType) Jaxb will deserialize this into null reference.
This null reference will cause later service add operations to fail. 

To overcome this we just simply skip unknown property types as property types are not mandatory
for the properties.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java bc90a8c 
  ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java 31cf80b


Diff: https://reviews.apache.org/r/40446/diff/


Testing
-------

Manual testing:
- Removed "TEXT" property type form PropertyInfo.PropertType enum (this way making "TEXT"
unkown to Ambari)
- Deployed a cluster with 3 nodes
- Added Ranger service to the cluster as Ranger service has properties with property type
"TEXT"
- Verified that Ranger service installed successfully.

Unit tests: currently in progress


Thanks,

Sebastian Toader


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message