ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 40433: Add support for ATS v1.5 for HDP versions 2.3 and higher
Date Wed, 18 Nov 2015 09:20:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40433/#review106997
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
(line 103)
<https://reviews.apache.org/r/40433/#comment165877>

    We can move out this check as well, properties which are not found will not lead to failure.
As we have lazy failing implemented for such a cases.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py (line
259)
<https://reviews.apache.org/r/40433/#comment165876>

    Is that possible to remove this check and simply check for existance of the properties
as you do below, this way it should work for all the stacks.
    
    And no need to add this hacky stack check.


- Andrew Onischuk


On Nov. 18, 2015, 8:18 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40433/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 8:18 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13936
>     https://issues.apache.org/jira/browse/AMBARI-13936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Starting HDP-2.3, Ambari should support ATSv1.5. This involves:
> Adding new configs as specified in the doc below. Lets add only the non-advanced configs
to the HDP-2.3 yarn-site (skip all configs after the section ADVANCED CONFIGS)
> Adding one new config to tez-site
> Ensure that the DFS paths are created and have right permissions
> property: yarn.timeline-service.entity-file-cache-store.active-dir (FSPermission 01777)
> property: yarn.timeline-service.entity-file-cache-store.done-dir (FSPermission 0700)
> Thing(s) to make sure:
> yarn.timeline-service.entity-file-cache-store.active-dir and done-dir exist on the cluster
on hdfs. Active dir should have permission 01777, owned by yarn-user, group hadoop-group.
Done dir should have permission 0700, owned by yarn-user, group hadoop-group.
> The Tez cache plugin class is in timeline server’s classpath - it should be the case
even now, but lets check
> yarn.timeline-service.leveldb-timeline-store.path is a path on local filesystem and needs
to be created with permissions 755 ( owner being the same user as the one which timeline server
is running as ) - this should be happening as well
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
cc42481 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
aa79fe4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/TEZ/configuration/tez-site.xml
37db69f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml
c9e617b 
> 
> Diff: https://reviews.apache.org/r/40433/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message