ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 40404: AMBARI-13926 : AMS log file not getting created
Date Tue, 17 Nov 2015 22:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40404/#review106948
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Nov. 17, 2015, 9:16 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40404/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 9:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-13926
>     https://issues.apache.org/jira/browse/AMBARI-13926
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The AMS logs were not getting created because the log4j.properties that was getting picked
up was from a jar file rather than the one which is AMS config driven. 
> 
> Fix
> Moved the code that had a dependency on the jar that supplied the wrong log4j.properties
to src/test. Hence, the jar will not be packaged during AMS jar assembly.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 1f76ba2 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/AMSJMeterLoadTest.java
187c3f1 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/AppGetMetric.java
727a1c7 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/GetMetricRequestInfo.java
26c5025 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/JmeterTestPlanTask.java
f7e27b1 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/loadsimulator/README
39e5365 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/loadsimulator/ams-jmeter.properties
3353d43 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/loadsimulator/amsJmeterGraph.jmx
06d6360 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/loadsimulator/jmeter.properties
9fcf7ca 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/loadsimulator/saveservice.properties
bae1168 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/AMS-HBASE.dat
91b524b 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/DATANODE.dat
74c121d 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/FLUME_HANDLER.dat
b8e5e92 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/HBASE.dat
ae60458 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/HOST.dat
96e7ddd 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/KAFKA_BROKER.dat
c8bb64b 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/NAMENODE.dat
81360c5 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/NIMBUS.dat
c407266 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/NODEMANAGER.dat
971c37f 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/resources/ui_metrics_def/RESOURCEMANAGER.dat
8c4aec5 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AMSJMeterLoadTest.java
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AppGetMetric.java
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/GetMetricRequestInfo.java
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/JmeterTestPlanTask.java
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/README
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/ams-jmeter.properties
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/amsJmeterGraph.jmx
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/jmeter.properties
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/saveservice.properties
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/AMS-HBASE.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/DATANODE.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/FLUME_HANDLER.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/HBASE.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/HOST.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/KAFKA_BROKER.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/NAMENODE.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/NIMBUS.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/NODEMANAGER.dat
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/resources/ui_metrics_def/RESOURCEMANAGER.dat
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40404/diff/
> 
> 
> Testing
> -------
> 
> Ambari-metrics unit tests pass.
> 
> Manually tested that the log file being created with the new jars. 
> 
> Manually tested the proper working of the moved Jmeter load simulator code.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message