ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Di Li" <d...@ca.ibm.com>
Subject Re: Review Request 40311: AMBARI-11964: Allow services to hide "custom" configurations
Date Tue, 17 Nov 2015 22:48:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40311/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 10:48 p.m.)


Review request for Ambari, Alexandr Antonenko and Jaimin Jetly.


Bugs: AMBARI-11964
    https://issues.apache.org/jira/browse/AMBARI-11964


Repository: ambari


Description
-------

Ambari backend already has such attribute defined for each configType (JIRA AMBARI-7404).
It's called "supports_adding_forbidden". The same as "supports_final", you need to set it
at the configType level. For example, if you want Ambari web UI to not show Custom hdfs-site
for HDFS, you should have the "configuration" section set like this <configuration supports_final="true"
supports_adding_forbidden="true">, in the hdfs-site.xml.

The issue here is that even though the Ambari server backend sends this information to the
UI as a JSON string, UI currently does not process it, thus no show/hide the Custom... sections
behavior observed even when the attribute is set to true.

The patch here proposed a fix to have the UI process the value and show/hide the Custom...
sections accordingly.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-conf.xml
94ae058 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/configuration/pig-properties.xml
b4217ca 
  ambari-web/app/models/stack_service.js 1926b9c 
  ambari-web/app/utils/config.js 1fba4d0 
  ambari-web/app/views/common/configs/service_config_view.js 0ef2112 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js ffbea76 
  ambari-web/test/utils/config_test.js e3906af 
  ambari-web/test/views/common/configs/service_config_view_test.js 1f0cd60 

Diff: https://reviews.apache.org/r/40311/diff/


Testing
-------

1. New unit tests.

2. Patched a cluster installed with trunk Ambari build, update various ...site.xml to have
the supports_adding_forbidden attribute set to true, restart ambari server, reload UI, verify
the corresponding Custom... sections are gone.


Thanks,

Di Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message