ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 40373: Create API entry points for getting authorization information
Date Tue, 17 Nov 2015 15:04:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40373/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 10:04 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sumit Mohanty.


Changes
-------

Cosmetic changes related to method location and documentation. Added missing properties to
property ID set.


Bugs: AMBARI-13916
    https://issues.apache.org/jira/browse/AMBARI-13916


Repository: ambari


Description
-------

Create API entry points for getting authorization information.  

The following entry points need to be created:
```
GET /api/v1/authorizations
GET /api/v1/permissions/:PERMISSION_ID/authorizations
GET /api/v1/users/:USERNAME/authorizations
```

The following entry points need to be updated to supply more information:
```
GET /api/v1/permissions/:PERMISSION_ID
```

# Note: The data layer is stubbed out and left for implementation in AMBARI-13865


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/PermissionResourceDefinition.java
56127b9 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
e7bbec4 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/PermissionService.java
594caba 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RoleAuthorizationService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java 05ee6b1

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 823ac8a

  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
0979298 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
0310fdc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fbbc7c8

  ambari-server/src/test/java/org/apache/ambari/server/api/resources/PermissionResourceDefinitionTest.java
0ad3b47 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
081a6eb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
ebe9b93 

Diff: https://reviews.apache.org/r/40373/diff/


Testing
-------

Manually tested

# Local test results: PASSED

# Jenkins test results: PENDING


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message