ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gautam Borad" <gbo...@gmail.com>
Subject Re: Review Request 39933: AMBARI-13706 : Ambari Alert for verifying if Ranger admin password is in sync between Ranger and Ambari
Date Tue, 17 Nov 2015 03:29:45 GMT


> On Nov. 16, 2015, 1:31 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py,
lines 126-131
> > <https://reviews.apache.org/r/39933/diff/2/?file=1126148#file1126148line126>
> >
> >     This is a pretty big change in behavior based on what this patch is actually
described to do.  The change here is going from throwing Fail to just logging an error.  If
there's an issue creating the repository, shouldn't that shouldn't get propagated?

@Nate, throwing Fail prevents the entire component from starting and that causes other major
issues ( eg. during RU, restart etc ). Also, most of the time the password of ambari user
is changed from the Ranger side and not on the Ambari side. This causes to Raise Fail and
prevent other components from starting, _even if_ the repo is already present in Ranger.

To avoid such scenarios, have converted from Raise to Logging ( which was the original behaviour
previously )


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39933/#review106655
-----------------------------------------------------------


On Nov. 16, 2015, 1:03 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39933/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev
Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy,
and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13706
>     https://issues.apache.org/jira/browse/AMBARI-13706
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains alert definition for checking credentials of Ranger Users (in Ambari):
'admin' and 'amb_ranger_admin'
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
4beeca9 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
328cf7f 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
1b5c6cb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 62f29eb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
036681c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
185ea5d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
4fc1423 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
1fef03f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
8b96763 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/alerts.json 2de5f87

>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml
837b26e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
439db46 
> 
> Diff: https://reviews.apache.org/r/39933/diff/
> 
> 
> Testing
> -------
> 
> Checked for Alerts in following conditions 
> 
> 1) Correct credentials for admin, amb_ranger_admin 
> 2) Invalid credential of admin user
> 3) Invalid credential of amb_ranger_admin user
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message