ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 40352: Add error logs to script alerts when there are failures
Date Mon, 16 Nov 2015 16:15:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40352/#review106675
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
(line 203)
<https://reviews.apache.org/r/40352/#comment165417>

    That would be nice to add tracebacks to the error messages as well, so we can quickly
diagnose those via UI as well as via logs.


- Andrew Onischuk


On Nov. 16, 2015, 4:03 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40352/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 4:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13905
>     https://issues.apache.org/jira/browse/AMBARI-13905
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In general, the script alerts need logging to cover error scenarios.
> For example:
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
>       json_response = json.loads(stdout)
>     except Exception, exception:
>       return (RESULT_CODE_CRITICAL, [str(exception) + str(stdout)])
> If the response is not a valid JSON Ambari should log the content rather than just reporting
that json could not be parsed through the alert text.
> Similar enhancements may be needed in several script based alerts. At least, lets cover
all the three alert scripts that are in HIVE.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
548a838 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py
bfc518f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py
be72327 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
7f23d31 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
8d8bd58 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
2c44b36 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py
912969a 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanagers_summary.py
11f29fd 
> 
> Diff: https://reviews.apache.org/r/40352/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message