ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 40300: Ranger Usersync Moving From Seconds to Millis On Stack Upgrade
Date Fri, 13 Nov 2015 16:47:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40300/#review106434
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Nov. 13, 2015, 11:39 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40300/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 11:39 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-13888
>     https://issues.apache.org/jira/browse/AMBARI-13888
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During upgrade, sync interval needs to be migrated properly.
> 
> In HDP 2.2, ranger treats this value in minutes {{usersync-properties.xml/SYNC_INTERVAL}}.
In HDP 2.3, the unit changed to milliseconds {{ranger-ugsync-site.xml/ranger.usersync.sleeptimeinmillisbetweensynccycle}}.
So upgrade should handle the transformation.
> 
> Yes, we _could_ write a Java class with performs "smart" checking and just multiplies
a modified value by 1000 - but that's a lot of work for really no benefit. Let's just correct
the value so that it doesn't hammer the server and set it  back to the stock value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml
d61cf20 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 518132e

>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.2_to_2.3.json 40c345d

> 
> Diff: https://reviews.apache.org/r/40300/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message