ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Review Request 40202: Ranger smart config - AD url missing ldap:// (or ldaps://)
Date Wed, 11 Nov 2015 23:30:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40202/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-13847
    https://issues.apache.org/jira/browse/AMBARI-13847


Repository: ambari


Description
-------

When configuring LDAP/AD for usersync in new Ranger smart config, Ambari should construct
the LDAP/AD url with prefix "ldap://". For example, the url should like "ldap://localhost:389"

When ambari is configurd with LDAP, ranger.usersync.ldap.url value should be set to authentication.ldap.primaryUrl
with ldap:// as the prefix if not using ssl and should be prefixed with ldaps:// if using
ssl.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7181122 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 7d2b625 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py f29d147 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py a1114fc 

Diff: https://reviews.apache.org/r/40202/diff/


Testing
-------

Verified that the patch works manually on a cluster.
Verified that ambari-server (inclusive of stack advisor tests) unit tests passes with the
patch
----------------------------------------------------------------------
Ran 238 tests in 6.900s
OK
----------------------------------------------------------------------
Total run:832
Total errors:0
Total failures:0
OK


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message