ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 40139: SKIPPED_FAILED state should not be bubbled up to the Upgrade level
Date Wed, 11 Nov 2015 19:45:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40139/#review106138
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Nov. 11, 2015, 2:30 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40139/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 2:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate
Cole, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13818
>     https://issues.apache.org/jira/browse/AMBARI-13818
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After discussing this on the call today, it was determined that the web client has enough
information to iterate over the data being returned to display the information correctly.
However, it's rather undesirable that they are retrieving all UpgradeGroup and UpgradeItem
structures on every request. So, they are going to change this so they only retrieve the UpgradeGroup.
> The best compromise here is to surface a new property that describes the display status
of upgrade group
> The new display_status field is used as information for the UI to use for display purposes
only. The status field will revert to its prior behavior. In this example UpgradeGroup is
COMPLETED but the UI has a hint to show SKIPPED_FAILED.
> We should do this for the following states:
> SKIPPED_FAILED
> FAILED
> 
> 
> Also fixes another blocker:
> STR:
> 1) Install and deploy cluster with older HDP version
> 2) Enable NameNode HA
> 3) Register, install new HDP version
> 4) Start Rolling Upgrade with "Skip all Service Check failures" and "Skip all Slave Component
failures" options
> 5) Break datanode_upgrade.py script and wait for Core Slaves failures
> 6) Click "Pause upgrade" on "Core Slaves - >Verifying Skipped Failures" step
> Result:
> Button "Resume upgrade" doesn't work. After clicking on this button I've got next http
response
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Can only set status to PENDING when
the upgrade is ABORTED (currently SKIPPED_FAILED)"
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
f87c32c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java
c4dcd27 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
4b8587f 
> 
> Diff: https://reviews.apache.org/r/40139/diff/
> 
> 
> Testing
> -------
> 
> checked on live cluster
> 
> mvn clean test in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message