ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 40141: HDP-2.3 does not have the ability to set heapsize for hive components
Date Wed, 11 Nov 2015 13:33:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review106049
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Nov. 11, 2015, 12:15 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 12:15 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13817
>     https://issues.apache.org/jira/browse/AMBARI-13817
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml
has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
>   export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
>   export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
3211b36 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
447993d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml
c331802 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml
30141c6 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
521dede 
> 
> Diff: https://reviews.apache.org/r/40141/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message