ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 40163: Add (descriptive) label to permission resource and database schema
Date Wed, 11 Nov 2015 00:37:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40163/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 7:37 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and Richard Zang.


Changes
-------

Previous patch was the wrong patch


Bugs: AMBARI-13814
    https://issues.apache.org/jira/browse/AMBARI-13814


Repository: ambari


Description
-------

Add (descriptive) label to permission resource and database schema to avoid having to hardcode
a descriptive name for a permission. For example:


Permission Name       | Permission Label
----------------------|------------------------
VIEW.USER             | View User
CLUSTER.USER          | Cluster User
SERVICE.OPERATOR      | Service Operator
SERVICE.ADMINISTRATOR | Service Administrator
CLUSTER.OPERATOR      | Cluster Operator
CLUSTER.ADMINISTRATOR | Cluster Administrator


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java
287c2e6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
db73774 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 804d97b

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c00e46f 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3cac618 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 2bcfb9a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 56dff9b 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1cc83ed 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 4b4b0d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
d1907b7 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java
ad704a5 
  ambari-views/docs/index.md 18f1fb3 
  ambari-views/examples/restricted-view/docs/index.md 78aced4 

Diff: https://reviews.apache.org/r/40163/diff/


Testing
-------

Manually tested API call on both fresh and upgraded installation

# Jenkins test results: PENDING


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message