ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 40134: In an upgraded cluster: JDK 1.8 option not available in ambari-server setup
Date Tue, 10 Nov 2015 23:45:24 GMT


> On Nov. 10, 2015, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py, line 983
> > <https://reviews.apache.org/r/40134/diff/1/?file=1121705#file1121705line983>
> >
> >     Should we add an unit test for future regressions?
> 
> Vitalyi Brodetskyi wrote:
>     We don't have UT for serverConfiguration.py at all. And i don't think this is the
critical place which can be corrupted. This code changes very rarely. But if you want i can
add test for this method.

Lets open a lower priority JIRA for this and take it up later.


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40134/#review105850
-----------------------------------------------------------


On Nov. 10, 2015, 3:01 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40134/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 3:01 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
> 
> 
> Bugs: AMBARI-13809
>     https://issues.apache.org/jira/browse/AMBARI-13809
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM: When going through 'ambari-server setup' and trying to change Oracle JDK version,
option for JDK 1.8 does not exist
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 95d59d8 
>   ambari-server/src/test/python/TestAmbariServer.py 301d91b 
> 
> Diff: https://reviews.apache.org/r/40134/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message