ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aravindan Vijayan" <avija...@hortonworks.com>
Subject Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit property to upgrade
Date Mon, 09 Nov 2015 23:41:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------

(Updated Nov. 9, 2015, 11:41 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
-------

Added old limit property to unit test.


Bugs: AMBARI-13798
    https://issues.apache.org/jira/browse/AMBARI-13798


Repository: ambari


Description
-------

The AMS result set size property was recently changed through AMBARI-13411. This bug addresses
the corresponding change to the upgrade path. Change log statements with respect to result
limit exceeded failures to make sure they convey what the limit vs requested size was.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
92d59e2 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36

  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
521dede 

Diff: https://reviews.apache.org/r/40110/diff/


Testing
-------

mvn clean test on ambari-metrics.

Manual testing done.

Added unit test to cover this case.


Thanks,

Aravindan Vijayan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message