ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39933: AMBARI-13706 : Ambari Alert for verifying if Ranger admin password is in sync between Ranger and Ambari
Date Mon, 09 Nov 2015 17:13:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39933/#review105699
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
(line 69)
<https://reviews.apache.org/r/39933/#comment164300>

    On my deployment, this is working whether I give a bad password or not.



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
(lines 90 - 93)
<https://reviews.apache.org/r/39933/#comment164299>

    Implies a 404 or 500 means that the credentials are bad which is confusing.  Should check
for 401 specifically?  On the java side, i'm making that a WARNING instead of FAIL when not
401.



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
(line 105)
<https://reviews.apache.org/r/39933/#comment164301>

    get_user_code cannot both be == 200 and "not none" this way.  May have to switch the logic
to do a None check first


- Nate Cole


On Nov. 9, 2015, 11:35 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39933/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 11:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev
Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy,
and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13706
>     https://issues.apache.org/jira/browse/AMBARI-13706
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains alert definition for checking credentials of Ranger Users (in Ambari):
'admin' and 'amb_ranger_admin'
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
4beeca9 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
328cf7f 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
1b5c6cb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 62f29eb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
036681c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
185ea5d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
4fc1423 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
1fef03f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
8b96763 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/alerts.json 2de5f87

>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml
837b26e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
439db46 
> 
> Diff: https://reviews.apache.org/r/39933/diff/
> 
> 
> Testing
> -------
> 
> Checked for Alerts in following conditions 
> 
> 1) Correct credentials for admin, amb_ranger_admin 
> 2) Invalid credential of admin user
> 3) Invalid credential of amb_ranger_admin user
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message