ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Zang" <rz...@hortonworks.com>
Subject Re: Review Request 40003: FE: Create a switchable "Role" section for admin view
Date Fri, 06 Nov 2015 02:21:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40003/
-----------------------------------------------------------

(Updated Nov. 6, 2015, 2:21 a.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
-------

Use bootstrap tooltip. Change Username to Name.


Bugs: AMBARI-13756
    https://issues.apache.org/jira/browse/AMBARI-13756


Repository: ambari


Description
-------

This is a FE implementation that creates a switchable "Role" section for admin view so that
user can switch between "block" and "list". This UI will not be visible until the entire project
is done.


Diffs (updated)
-----

  ambari-admin/src/main/resources/ui/admin-web/app/index.html fe049ac 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
6aae599 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js f34d931 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js fdfb8e2 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css ff963ee 
  ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html d5dcfa2

  ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html PRE-CREATION


Diff: https://reviews.apache.org/r/40003/diff/


Testing
-------

Manually tested on live cluster.
All unit tests passed.
INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket cHgn_uh6bsd462mEhdYK with id 5568272
PhantomJS 1.9.7 (Mac OS X): Executed 13 of 13 SUCCESS (0.012 secs / 0.102 secs)


Thanks,

Richard Zang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message