ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangeeta Ravindran" <sangeeta.e.ravind...@gmail.com>
Subject Review Request 39883: Alert notification create/edit/duplicate menu items should be disabled for non-admin users
Date Wed, 04 Nov 2015 18:31:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39883/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-13347
    https://issues.apache.org/jira/browse/AMBARI-13347


Repository: ambari


Description
-------

If you log in as a non-admin operator user, and try to create an alert or edit/duplicate an
existing alert and click on Save in the Manager Alert Notifications wizard, the UI seems to
hang because the user is an operator and does not have the permission to access the resources
related to alert management (underlying error HTTP 403).
The create/edit/alert options should be disabled for non-admin operator users since only admins
have privileges to add/edit alert notifications.


Diffs
-----

  ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs ed18c63 
  ambari-web/app/views/main/alerts/manage_alert_notifications_view.js c85d534 
  ambari-web/test/views/main/alerts/manage_alert_notifications_view_test.js a2822ce 

Diff: https://reviews.apache.org/r/39883/diff/


Testing
-------

Did manual verification of the fix. Also updated test in manage_alert_notifications_view_test.js.

Ran "mvn clean test" for ambari-web project and build ran successfully.

10080 tests complete (16 seconds)
105 tests pending


Thanks,

Sangeeta Ravindran


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message