ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39918: Finalize is invoked when it is sure to fail when there a failures that have been skipped during RU
Date Wed, 04 Nov 2015 02:28:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 9:28 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.


Bugs: AMBARI-13704
    https://issues.apache.org/jira/browse/AMBARI-13704


Repository: ambari


Description
-------

Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.

Debatable whether Express needs this - can be removed if needed.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
22fc4c0 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/39918/diff/


Testing (updated)
-------

Manual verification + automated:

Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:59.689s
[INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
[INFO] Final Memory: 34M/1417M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message