ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39864: Changing "Skip service check failure" and "Skip slave component failure" options after RU is kicked off does not work
Date Mon, 02 Nov 2015 21:54:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39864/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 4:54 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.


Bugs: AMBARI-13681
    https://issues.apache.org/jira/browse/AMBARI-13681


Repository: ambari


Description
-------

Previous to this patch, the code would issue an UPDATE statement for all host_role_commands.
 However, this would never update the JPA-cached values even though the db was correct.  Changing
each entity resulted in the desired affect.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
7978a7a 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 14af03d

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
1806f4c 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java
d7e9149 

Diff: https://reviews.apache.org/r/39864/diff/


Testing (updated)
-------

Manual testing:

Tests run: 3323, Failures: 0, Errors: 0, Skipped: 35

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:45.702s
[INFO] Finished at: Mon Nov 02 16:52:17 EST 2015
[INFO] Final Memory: 34M/1105M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message