ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Review Request 39859: Make it configurable as to how frequently ActionScheduler scans DB for tasks
Date Mon, 02 Nov 2015 14:51:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39859/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.


Bugs: AMBARI-13678
    https://issues.apache.org/jira/browse/AMBARI-13678


Repository: ambari


Description
-------

ActionScheduler now sleeps only 1 second between scans while it was sleeping for 10 seconds
before. We should make it configurable where user can set the delay. Users with slower DB
would rather have ActionScheduler not work so aggressively.
Currently, it is hard coded to 1 second.
bindConstant().annotatedWith(Names.named("schedulerSleeptime")).to(1000L);
Lets add a config parameter to ambari.properties - server.execution.scheduler.wait and default
should be 1 second. If the value is more than 60 second then it should automatically set to
60 second with a log saying so.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 26e20e8

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 60217c0

  ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
0f349fa 

Diff: https://reviews.apache.org/r/39859/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message