Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AD8918322 for ; Fri, 30 Oct 2015 19:14:27 +0000 (UTC) Received: (qmail 57989 invoked by uid 500); 30 Oct 2015 19:14:26 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 57954 invoked by uid 500); 30 Oct 2015 19:14:26 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 57936 invoked by uid 99); 30 Oct 2015 19:14:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2015 19:14:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 891B32A8391; Fri, 30 Oct 2015 19:14:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2701329578044216045==" MIME-Version: 1.0 Subject: Re: Review Request 39773: Various metrics show no data available - when HA enabled From: "Sid Wagle" To: "Mahadev Konar" , "Myroslav Papirkovskyy" , "Dmytro Sen" Cc: "Sid Wagle" , "Ambari" Date: Fri, 30 Oct 2015 19:14:25 -0000 Message-ID: <20151030191425.22462.40366@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39773/ X-Sender: "Sid Wagle" References: <20151029223119.22461.71410@reviews.apache.org> In-Reply-To: <20151029223119.22461.71410@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============2701329578044216045== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39773/ ----------------------------------------------------------- (Updated Oct. 30, 2015, 7:14 p.m.) Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy. Changes ------- Added safeguard against NPE. Bugs: AMBARI-13641 https://issues.apache.org/jira/browse/AMBARI-13641 Repository: ambari Description ------- The Metrics Cache introduced in Ambari stores the metrics result in an HashMap with metric name as the key. This results in a problem when the same request needs to fetch metrics for both the Namenodes or both the Resourcemangers. The last result gets cached. *Note*: Workaround for this is to disable cache in 2.1.2 by setting this property in ambari.properties file : server.timeline.metrics.cache.disabled = true Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java 9e343e3 ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java e8a2aef ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheSizeOfEngine.java d8f2e06 ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheValue.java 4b22898 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java 54e8123 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheTest.java 0abe636 Diff: https://reviews.apache.org/r/39773/diff/ Testing ------- Manaully verified. Relevant unit test pass. Thanks, Sid Wagle --===============2701329578044216045==--